Code

#18550 closed Bug (fixed)

history_view shows no log entries for PKs requiring unqote()

Reported by: josh.oosterman@… Owned by: nobody
Component: contrib.admin Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

An object with an object_id like 'foo:bar' will never show any history records because history_view doesn't unquote it.

Partial fix in #12349 touched object lookup but not LogEntry lookup.

Attachments (1)

unquote_history_view.patch (1.9 KB) - added by josh.oosterman@… 22 months ago.

Download all attachments as: .zip

Change History (3)

Changed 22 months ago by josh.oosterman@…

comment:1 Changed 22 months ago by julien

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

Thanks. I'll push the fix in a moment.

comment:2 Changed 22 months ago by Julien Phalip <jphalip@…>

  • Resolution set to fixed
  • Status changed from new to closed

In [2cd4cf58d32c5d4b163a466f608dff31bac66b87]:

Fixed #18550 -- Ensured that the admin history view works with escaped primary keys.
Thanks to josh.oosterman for the report and patch.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.