`django.utils.version.get_svn_revision` isn't appropriate anymore

[Aymeric Augustin]

We're no longer using SVN.

Callers of this function, like django.get_version, need to be updated.

[Aymeric Augustin]

Here's an in-place replacement for the existing functionality.

We can't use the SHA1 of the changeset because the identifier must be numeric.

We can use either a human readable timestamp (14 digits) or a Unix timestamp (10 digits). I implemented the first one, even though it's longer, because it will be easier to locate the corresponding changeset in GitHub (or any other git UI).

[Aymeric Augustin]

#18228 was a duplicate.

[Daniel Swarbrick]

Perhaps it might be a good idea to append the abbreviated commit hash to the date in the 'git show' command, eg

git show --pretty=format:%ct-%H --quiet HEAD

which yields an output like '1335619144-10cade8fac143984fc8416f3179c955e9f0c7f7b'. Github appears to use 10-digit abbreviated hashes, as opposed to Git's 7-digit ones. If the commit hash was shown in the version number, using the same format/length as Github, this would make it even easier to locate the commit. Also, if the commit hash is explicitly included in the version stamp, perhaps the timestamp could just be a Unix timestamp afterall.

[Aymeric Augustin]

Unfortunately we can't include the hash because the version number would no longer comply with PEP 386.

[Daniel Swarbrick]

In that case the "devN" suffix becomes rather useless, or at the very least, quite inconvenient. Is it worth adding a separate function (not used to build the version stamp) which actually does return the Git commit hash?

[Aymeric Augustin]

If we don't include this suffix, all post-1.4 versions will be labeled 1.5, which is rather confusing. The suffix makes it clear that it's a development version.

Where would Django use a Python function returning the git commit hash?

[Aymeric Augustin]

Fixed in 02a5b41db4ff8544f93a5d9854b346a9aae4f556.

[Daniel Swarbrick]

I didn't suggest not including the suffix. I suggested included a function to retrieve the git commit hash, for debugging purposes, to make it easy to locate the particular code revision now that Django is hosted on github.