Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#18131 closed Bug (fixed)

ContentTypeManager.get_for_id not documented

Reported by: Sergey Fedoseev Owned by: nobody
Component: Documentation Version: 1.4
Severity: Normal Keywords:
Cc: Sergey Fedoseev, timograham@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Karen Tracey)

get_for_id is not listed among ContentTypeManager methods.

The only mention of caching is in description of clear_cache method, but documentation should say that get_* methods are cached and using them is preferred way to get ContentType.

Attachments (1)

18131.diff (746 bytes) - added by Tim Graham 4 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 years ago by Sergey Fedoseev

Component: UncategorizedDocumentation

Sorry, get_for_id should be in description instead of get_for_model.

Last edited 5 years ago by Sergey Fedoseev (previous) (diff)

comment:2 Changed 5 years ago by Jannis Leidel

Triage Stage: UnreviewedAccepted
Type: UncategorizedBug

comment:3 Changed 4 years ago by Tim Graham

Resolution: fixed
Status: newclosed

comment:4 Changed 4 years ago by Sergey Fedoseev

Cc: Sergey Fedoseev added
Resolution: fixed
Status: closedreopened

I see no changes there for fixing this bug.

comment:5 Changed 4 years ago by Karen Tracey

Description: modified (diff)

Corrected name of undocumented method in original description.

Changed 4 years ago by Tim Graham

Attachment: 18131.diff added

comment:6 Changed 4 years ago by Tim Graham

Cc: timograham@… added
Has patch: set
Summary: insufficient info about ContentTypeManagerContentTypeManager.get_for_id not documented

comment:7 Changed 4 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: reopenedclosed

In 93e6733e4cbbdad34f1f0f59303ae01f577e4e58:

Fixed #18131 - Documented ContentTypeManager.get_for_id; thanks sir_sigurd for the report.

comment:8 Changed 4 years ago by Tim Graham <timograham@…>

In 421ce44e8bb7386d1f5826d0473a3e24f6075d35:

[1.4.x] Fixed #18131 - Documented ContentTypeManager.get_for_id; thanks sir_sigurd for the report.

Backport of 93e6733e4cbbdad34f1f0f59303ae01f577e4e58 from master.

Note: See TracTickets for help on using tickets.
Back to Top