Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#18104 closed Bug (fixed)

python_markdown_deprecation incorrectly formed

Reported by: Roy Smith Owned by: Claude Paroz
Component: contrib.markup Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In /contrib/markup/templatetags/markup.py, this code is incorrect:

            python_markdown_deprecation = "The use of Python-Markdown "
            "< 2.1 in Django is deprecated; please update to the current version"

I suspect you were attempting to use string concatenation, but what you've got is two statements, one assigning a string, the next consisting of just a string. This results in:

[...]/markup.py:83: DeprecationWarning: The use of Python-Markdown 
  warnings.warn(python_markdown_deprecation, DeprecationWarning)

Attachments (1)

18104.diff​ (890 bytes ) - added by sage 13 years ago.
Patch

Download all attachments as: .zip

Change History (5)

comment:1 by Claude Paroz, 13 years ago

Owner: changed from nobody to Claude Paroz
Status: new → assigned
Triage Stage: Unreviewed → Accepted

by sage, 13 years ago

Attachment: 18104.diff​ added

Patch

comment:2 by sage, 13 years ago

Has patch: set

comment:3 by Claude Paroz, 13 years ago

Resolution: → fixed
Status: assigned → closed

In [17897]:

[1.4.X] Fixed #18104 -- Added missing parentheses around two-lines deprecation string. Thanks Roy Smith for the report.

comment:4 by Claude Paroz, 13 years ago

I didn't touch the code in trunk, as it will be removed (see #18041).

Note: See TracTickets for help on using tickets.
Back to Top