#18020 closed Cleanup/optimization (needsinfo)
Refactoring loaddata step 2: compression_types
| Reported by: | hoffmaje | Owned by: | hoffmaje |
|---|---|---|---|
| Component: | Core (Management commands) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Step 1 was: ticket:18017
Here, it feels better to have:
- compression_types initialized in
__init__ - no indirection with the boolean
has_bz2
Existing tests pass.
Attachments (1)
Change History (4)
by , 13 years ago
| Attachment: | loaddata_refactor_compression_types.diff added |
|---|
comment:1 by , 13 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 13 years ago
| Resolution: | → needsinfo |
|---|---|
| Status: | assigned → closed |
| Summary: | [patch] refactoring loaddata step 2: compression_types → Refactoring loaddata step 2: compression_types |
comment:3 by , 13 years ago
The idea of this and #18017 was to simplify the code in the loaddata command. I agree with the idea: the loaddata command needs some cleanup (~10 levels of indentation). But the approach taken in these patches is IMHO not the correct one. The command doesn't need cosmetic enchantments, it needs a more thorough cleanup.
So, I agree with the close of this ticket (and #18017), but cleanup of loaddata is still a good idea.
Note:
See TracTickets
for help on using tickets.
Closing as I don't know what this is suppose to fix.