Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18020 closed Cleanup/optimization (needsinfo)

Refactoring loaddata step 2: compression_types

Reported by: hoffmaje Owned by: hoffmaje
Component: Core (Management commands) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Step 1 was: ticket:18017

Here, it feels better to have:

  • compression_types initialized in __init__
  • no indirection with the boolean has_bz2

Existing tests pass.

Attachments (1)

loaddata_refactor_compression_types.diff (3.8 KB) - added by hoffmaje 3 years ago.

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by hoffmaje

comment:1 Changed 3 years ago by hoffmaje

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to hoffmaje
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 3 years ago by jezdez

  • Resolution set to needsinfo
  • Status changed from assigned to closed
  • Summary changed from [patch] refactoring loaddata step 2: compression_types to Refactoring loaddata step 2: compression_types

Closing as I don't know what this is suppose to fix.

comment:3 Changed 3 years ago by akaariai

The idea of this and #18017 was to simplify the code in the loaddata command. I agree with the idea: the loaddata command needs some cleanup (~10 levels of indentation). But the approach taken in these patches is IMHO not the correct one. The command doesn't need cosmetic enchantments, it needs a more thorough cleanup.

So, I agree with the close of this ticket (and #18017), but cleanup of loaddata is still a good idea.

Note: See TracTickets for help on using tickets.
Back to Top