Opened 5 years ago

Closed 5 years ago

#18017 closed Cleanup/optimization (needsinfo)

Refactoring loaddata step 1: transaction rollback

Reported by: hoffmaje Owned by: hoffmaje
Component: Core (Management commands) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description


Attachments (1)

loaddata_refactored.diff (2.8 KB) - added by hoffmaje 5 years ago.

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by hoffmaje

Attachment: loaddata_refactored.diff added

comment:1 Changed 5 years ago by hoffmaje

Owner: changed from nobody to hoffmaje
Status: newassigned

comment:2 Changed 5 years ago by Anssi Kääriäinen

I wonder if the right approach is to do the refactoring one small piece at a time. To me the loaddata looks like it will need a total rewrite.

If one small piece at a time is the preferred approach, then the attached patch looks correct.

comment:3 Changed 5 years ago by hoffmaje

I think the same. But I felt that having the obvious pieces right in place may ease the rewrite.

comment:4 Changed 5 years ago by hoffmaje

Summary: [patch] refactoring loaddata transaction rollback[patch] refactoring loaddata step 1: transaction rollback

comment:5 Changed 5 years ago by hoffmaje

Step 2: ticket:18020

comment:6 Changed 5 years ago by Jannis Leidel

Resolution: needsinfo
Status: assignedclosed
Summary: [patch] refactoring loaddata step 1: transaction rollbackRefactoring loaddata step 1: transaction rollback

Hm, what is this ticket suppose to fix?

Note: See TracTickets for help on using tickets.
Back to Top