Opened 12 years ago
Closed 12 years ago
#18017 closed Cleanup/optimization (needsinfo)
Refactoring loaddata step 1: transaction rollback
| Reported by: | hoffmaje | Owned by: | hoffmaje |
|---|---|---|---|
| Component: | Core (Management commands) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Attachments (1)
Change History (7)
by , 12 years ago
| Attachment: | loaddata_refactored.diff added |
|---|
comment:1 by , 12 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 12 years ago
comment:3 by , 12 years ago
I think the same. But I felt that having the obvious pieces right in place may ease the rewrite.
comment:4 by , 12 years ago
| Summary: | [patch] refactoring loaddata transaction rollback → [patch] refactoring loaddata step 1: transaction rollback |
|---|
comment:6 by , 12 years ago
| Resolution: | → needsinfo |
|---|---|
| Status: | assigned → closed |
| Summary: | [patch] refactoring loaddata step 1: transaction rollback → Refactoring loaddata step 1: transaction rollback |
Hm, what is this ticket suppose to fix?
Note:
See TracTickets
for help on using tickets.
I wonder if the right approach is to do the refactoring one small piece at a time. To me the loaddata looks like it will need a total rewrite.
If one small piece at a time is the preferred approach, then the attached patch looks correct.