Code

Opened 2 years ago

Closed 22 months ago

Last modified 22 months ago

#17997 closed Cleanup/optimization (fixed)

unexpected multi-threaded dev server!

Reported by: trey.smith@… Owned by: vanessagomes
Component: Documentation Version: 1.4
Severity: Release blocker Keywords:
Cc: valhallasw@…, vanessagomes Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

On installing Django 1.4 I was surprised to find that:

  • The dev server now has a multi-threaded mode (great)
  • The new multi-threaded mode is used by default (surprisingly aggressive)
  • The release notes don't mention the new feature at all! (really?!)

The new multi-thread mode caused some problems for me with threads trying to use shared database connections which I will detail in another ticket. The thing I am pointing out here is that multi-threading is a big change, likely to cause many issues, and it took me totally by surprise.

I think the release notes should mention it and detail how to use --nothread to turn it off in case of problems.

Thanks!

Attachments (1)

ticket17997-patch1.diff (1.2 KB) - added by vanessagomes 22 months ago.
Suggestion for the docs.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 2 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Er, --nothread should be --nothreading

comment:2 Changed 2 years ago by jezdez

  • Triage Stage changed from Unreviewed to Accepted
  • Type changed from Bug to Cleanup/optimization

comment:3 Changed 2 years ago by valhallasw

  • Cc valhallasw@… added

comment:4 follow-up: Changed 2 years ago by akaariai

  • Severity changed from Normal to Release blocker

This was reported again in #18126. A quote from that ticket (by onyxfish):

I stumbled across the new --nothreading option. It says to read more in the release notes, but this isn't mentioned in the release notes. This really tripped me
up when a threading bug appeared in development code where I did not think such a thing was possible.

I am not sure where this should be patched: 1.4 branch, trunk or both?

comment:5 in reply to: ↑ 4 Changed 2 years ago by aaugustin

Replying to akaariai:

I am not sure where this should be patched: 1.4 branch, trunk or both?

I'd say "both".

comment:6 Changed 22 months ago by vanessagomes

  • Owner changed from nobody to vanessagomes

Changed 22 months ago by vanessagomes

Suggestion for the docs.

comment:7 Changed 22 months ago by vanessagomes

  • Cc vanessagomes added
  • Has patch set

comment:8 Changed 22 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In [e4a1407a9cf35e6449136c22647a58cb14451e7a]:

Fixed #17997 - Documented that the debug server is now multithreaded by default.

Thanks trey.smith@ for the report and vanessagomes for the patch.

comment:9 Changed 22 months ago by Tim Graham <timograham@…>

In [f5db3bddb34f7a2b5807b5af74dc49863fe5f06b]:

[1.4.X] Fixed #17997 - Documented that the debug server is now multithreaded by default.

Thanks trey.smith@ for the report and vanessagomes for the patch.

Backport of e4a1407a9c from master

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.