Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#17997 closed Cleanup/optimization (fixed)

unexpected multi-threaded dev server!

Reported by: trey.smith@… Owned by: vanessagomes
Component: Documentation Version: 1.4
Severity: Release blocker Keywords:
Cc: valhallasw@…, vanessagomes Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

On installing Django 1.4 I was surprised to find that:

  • The dev server now has a multi-threaded mode (great)
  • The new multi-threaded mode is used by default (surprisingly aggressive)
  • The release notes don't mention the new feature at all! (really?!)

The new multi-thread mode caused some problems for me with threads trying to use shared database connections which I will detail in another ticket. The thing I am pointing out here is that multi-threading is a big change, likely to cause many issues, and it took me totally by surprise.

I think the release notes should mention it and detail how to use --nothread to turn it off in case of problems.

Thanks!

Attachments (1)

ticket17997-patch1.diff (1.2 KB ) - added by vanessagomes 12 years ago.
Suggestion for the docs.

Download all attachments as: .zip

Change History (10)

comment:1 by anonymous, 12 years ago

Er, --nothread should be --nothreading

comment:2 by Jannis Leidel, 12 years ago

Triage Stage: UnreviewedAccepted
Type: BugCleanup/optimization

comment:3 by valhallasw, 12 years ago

Cc: valhallasw@… added

comment:4 by Anssi Kääriäinen, 12 years ago

Severity: NormalRelease blocker

This was reported again in #18126. A quote from that ticket (by onyxfish):

I stumbled across the new --nothreading option. It says to read more in the release notes, but this isn't mentioned in the release notes. This really tripped me
up when a threading bug appeared in development code where I did not think such a thing was possible.

I am not sure where this should be patched: 1.4 branch, trunk or both?

in reply to:  4 comment:5 by Aymeric Augustin, 12 years ago

Replying to akaariai:

I am not sure where this should be patched: 1.4 branch, trunk or both?

I'd say "both".

comment:6 by vanessagomes, 12 years ago

Owner: changed from nobody to vanessagomes

by vanessagomes, 12 years ago

Attachment: ticket17997-patch1.diff added

Suggestion for the docs.

comment:7 by vanessagomes, 12 years ago

Cc: vanessagomes added
Has patch: set

comment:8 by Tim Graham <timograham@…>, 12 years ago

Resolution: fixed
Status: newclosed

In [e4a1407a9cf35e6449136c22647a58cb14451e7a]:

Fixed #17997 - Documented that the debug server is now multithreaded by default.

Thanks trey.smith@ for the report and vanessagomes for the patch.

comment:9 by Tim Graham <timograham@…>, 12 years ago

In [f5db3bddb34f7a2b5807b5af74dc49863fe5f06b]:

[1.4.X] Fixed #17997 - Documented that the debug server is now multithreaded by default.

Thanks trey.smith@ for the report and vanessagomes for the patch.

Backport of e4a1407a9c from master

Note: See TracTickets for help on using tickets.
Back to Top