Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17908 closed Bug (fixed)

markdown tests fail if older version of markdown installed

Reported by: ptone Owned by: ptone
Component: contrib.markup Version: master
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

r17735 introduced a number of changes regarding the use of the markdown library including some new tests requiring a feature only present in markdown 2.1

These tests should be skipped unless a qualifying version of markdown is available.

Attachments (2)

markdown-test-fix.diff (1.6 KB) - added by ptone 3 years ago.
markdown-test-fix-1.3.X.diff (1.5 KB) - added by ptone 3 years ago.

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by ptone

Changed 3 years ago by ptone

comment:1 Changed 3 years ago by ptone

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 3 years ago by julien

  • Resolution set to fixed
  • Status changed from new to closed

In [17749]:

Fixed #17908 -- Made some contrib.markup tests be skipped so they don't fail on old versions of Markdown. Thanks to Preston Holmes for the patch.

comment:3 Changed 3 years ago by julien

In [17750]:

[1.3.X] Fixed #17908 -- Made some contrib.markup tests be skipped so they don't fail on old versions of Markdown. Thanks to Preston Holmes for the patch.

Backport of r17749 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top