Opened 5 years ago

Closed 5 years ago

#17891 closed Uncategorized (fixed)

Password reset email - small backwards incompatiblitity

Reported by: Dan Fairs Owned by: nobody
Component: Documentation Version: 1.4-beta-1
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no


This feature:

introduced a small backwards incompatibility for those users whose application have custom password reset forms - the save() method on the form now needs to take an extra parameter. This isn't noted in the backwards incompatible changes.

I've prepared a small note in those docs, in this pull request:

Attachments (1)

17891.patch (870 bytes) - added by Luke Granger-Brown 5 years ago.
Uploaded patch from here, just in case

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by Luke Granger-Brown

Attachment: 17891.patch added

comment:1 Changed 5 years ago by Luke Granger-Brown

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

Looks good and applies cleanly here - uploaded the patch file here just in case - I dunno what the core team what in terms of patches and pull requests.

Moved to accepted.

comment:2 Changed 5 years ago by Julien Phalip

Resolution: fixed
Status: newclosed

In [17705]:

Fixed #17891 -- Documented a small backwards incompatibility in the password_reset auth view. Thanks to danfairs and lukegb.

Note: See TracTickets for help on using tickets.
Back to Top