Code

Opened 2 years ago

Closed 2 years ago

#17891 closed Uncategorized (fixed)

Password reset email - small backwards incompatiblitity

Reported by: danfairs Owned by: nobody
Component: Documentation Version: 1.4-beta-1
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

This feature:

https://code.djangoproject.com/ticket/12202

introduced a small backwards incompatibility for those users whose application have custom password reset forms - the save() method on the form now needs to take an extra parameter. This isn't noted in the backwards incompatible changes.

I've prepared a small note in those docs, in this pull request:

https://github.com/django/django/pull/124

Attachments (1)

17891.patch (870 bytes) - added by lukegb 2 years ago.
Uploaded patch from https://github.com/danfairs/django/commit/08a697d8efad87690817c71714ce25547f2e2996.diff here, just in case

Download all attachments as: .zip

Change History (3)

Changed 2 years ago by lukegb

comment:1 Changed 2 years ago by lukegb

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Looks good and applies cleanly here - uploaded the patch file here just in case - I dunno what the core team what in terms of patches and pull requests.

Moved to accepted.

comment:2 Changed 2 years ago by julien

  • Resolution set to fixed
  • Status changed from new to closed

In [17705]:

Fixed #17891 -- Documented a small backwards incompatibility in the password_reset auth view. Thanks to danfairs and lukegb.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.