Opened 12 years ago
Closed 9 years ago
#17890 closed Bug (fixed)
django.contrib.admin.site extra_context
| Reported by: | Riccardo Di Virgilio | Owned by: | Berker Peksag |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Normal | Keywords: | extra_context |
| Cc: | stephenmuss@…, Tim Martin | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
hi, in django.contrib.admin.site the method password_change do not support extra_context, i think it's a minor bug to be fixed.
Change History (10)
comment:1 Changed 12 years ago by
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 Changed 11 years ago by
| Cc: | stephenmuss@… added |
|---|---|
| Has patch: | set |
comment:3 Changed 11 years ago by
| Needs tests: | set |
|---|
comment:5 Changed 11 years ago by
| Keywords: | extra_context added |
|---|
comment:6 Changed 11 years ago by
I closed the previous pull request and opened a new one at https://github.com/django/django/pull/499.
comment:7 Changed 11 years ago by
| Needs documentation: | set |
|---|---|
| Patch needs improvement: | set |
Hi,
I didn't understand the use case of this extra_context.
I think the same result it's possible to achieve overwriting the template.
Can you explain better the use case of this new extra_context?
For the patch/pull request:
1 - It'd need to update docs:
https://docs.djangoproject.com/en/dev/topics/auth/default/#django.contrib.auth.views.password_change
2 - It'd need to update the provided template, currently it's ignoring extra_context
Thanks.
comment:8 Changed 10 years ago by
| Cc: | Tim Martin added |
|---|
Since the ticket was opened, each_context() has been added to the AdminSite class, so it's possible to provide additional context fields by subclassing AdminSite and overriding each_context(). Does this make this ticket unnecessary? I'll happily fix up the patch if it's useful, but I don't want to do that if the feature is no longer needed.
comment:9 Changed 9 years ago by
| Needs documentation: | unset |
|---|---|
| Owner: | changed from nobody to Berker Peksag |
| Patch needs improvement: | unset |
| Status: | new → assigned |
comment:10 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Have created a patch and submitted a pull request at https://github.com/django/django/pull/64
This is no longer current. A new pull request has been opened at https://github.com/django/django/pull/499.