Opened 5 years ago

Closed 5 years ago

#17723 closed Bug (fixed)

Documentation update for language code URL sniffing regression

Reported by: Ryan Kaskel Owned by: nobody
Component: Documentation Version: 1.4-beta-1
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

#17720 reports and r17547 fixes a regression related to the LocaleMiddleware sniffing language codes in the URL's path.

The patch required adding a keyword argument to django.utils.translation.get_language_from_request, which is a publicly documented function.

Attached is a doc patch noting the change.

Attachments (1)

17723.diff (998 bytes) - added by Ryan Kaskel 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by Ryan Kaskel

Attachment: 17723.diff added

comment:1 Changed 5 years ago by Ryan Kaskel

Triage Stage: UnreviewedReady for checkin

comment:2 Changed 5 years ago by Anssi Kääriäinen

The only question I have is if check_path is the right name for that parameter. Maybe check_url/check_url_path would be more descriptive? I didn't realize the function was a public one, so good catch there!

Just bike shedding here, so let the committer decide. I guess the current name is OK too.

comment:3 Changed 5 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

In [17627]:

Fixed #17723 -- Mentioned the changes done in r17547. Thanks, ryankask.

Note: See TracTickets for help on using tickets.
Back to Top