#17488 closed Bug (fixed)
Failing WeekArchive tests
Reported by: | Florian Apolloner | Owned by: | nobody |
---|---|---|---|
Component: | Generic views | Version: | 1.3 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The problem is that 1.1.year is not necessarily in the first week -- it can be in week 0 (this is usually the case if the first day of the year is no sunday). Hence I attached a patch which checks for the 7.1.year which is always in the first week of the year.
Attachments (1)
Change History (5)
by , 13 years ago
comment:1 by , 13 years ago
Component: | Uncategorized → Generic views |
---|---|
Triage Stage: | Unreviewed → Accepted |
Type: | Uncategorized → Bug |
comment:2 by , 13 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
Actually, Python doesn't follow ISO here; the docs for strftime / strptime imply that week 1 starts on the first Sunday or Monday of the year. So 7 was correct.
Note:
See TracTickets
for help on using tickets.
http://en.wikipedia.org/wiki/ISO_8601#Week_dates says that a valid definition of week 1 is "the week with 4 January in it". So I'm going to use "4.1.year".