Opened 5 years ago

Closed 5 years ago

#17458 closed Bug (fixed)

Http404 untranslatable strings

Reported by: Claude Paroz Owned by: nobody
Component: Internationalization Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Several Http404 errors throughout django codebase are not set as translatable. For contrib apps that are not yet translatable, I don't think it's worth triggering the translation machinery, but for those who already have a locale dir, I'll prepare a patch.

Attachments (1)

17458-1.diff (6.1 KB) - added by Claude Paroz 5 years ago.
Set Http404 strings as translatable

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by Claude Paroz

Attachment: 17458-1.diff added

Set Http404 strings as translatable

comment:1 Changed 5 years ago by Claude Paroz

Has patch: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 5 years ago by Aymeric Augustin

Triage Stage: UnreviewedAccepted

comment:3 Changed 5 years ago by Karen Tracey

Note Http404 strings are debug information -- these are only shown to users when DEBUG is True. We don't generally translate development/debug strings, do we?

comment:4 Changed 5 years ago by Claude Paroz

Karen, you are right in that currently these messages are not shown to the user when DEBUG is False. But I think it's still valuable to have them translated (it's already the case for other 404 errors in Django code). I even think that we might one day pass this information to the handlerxxx callbacks, so that custom 404 templates may choose to display more detailed output, if desired (an idea for a new ticket!).

comment:5 Changed 5 years ago by Jannis Leidel

Yeah, I agree we need to be consistent with regard to translating the 404 debug information, and I'd prefer having translated error messages if possible.

comment:6 Changed 5 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

In [17447]:

Fixed #17458 -- Marked Http404 error messages for translation. Thanks, Claude Paroz.

Note: See TracTickets for help on using tickets.
Back to Top