Opened 4 years ago

Closed 4 years ago

#17457 closed Bug (fixed)

Untranslated algorithm/salt/hash in ReadOnlyPasswordHashWidget

Reported by: claudep Owned by: nobody
Component: Internationalization Version: 1.4-alpha-1
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In the new readonly password field widget in the admin User page, the displayed keys of the hasher are not translated. Working on a patch.

Attachments (1)

17457-1.diff (3.9 KB) - added by claudep 4 years ago.
Translate hasher keys in password widget

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by claudep

Translate hasher keys in password widget

comment:1 Changed 4 years ago by claudep

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I'm unsure about tests. Are they needed her?

comment:2 Changed 4 years ago by aaugustin

In such cases, I don't believe tests are really useful. The chance of a regression is negligible, testing generated HTML is fragile, as is depending on .mo files. But I'm more laxist than other core devs in this area.

comment:3 Changed 4 years ago by aaugustin

  • Triage Stage changed from Unreviewed to Accepted

comment:4 Changed 4 years ago by ramiro

  • Triage Stage changed from Accepted to Ready for checkin

I agree with Aymeric.

comment:5 Changed 4 years ago by aaugustin

  • Resolution set to fixed
  • Status changed from new to closed

In [17270]:

Fixed #17457 -- Marked strings used in hash descriptions for translation.

Note: See TracTickets for help on using tickets.
Back to Top