Opened 5 years ago

Closed 5 years ago

#17457 closed Bug (fixed)

Untranslated algorithm/salt/hash in ReadOnlyPasswordHashWidget

Reported by: Claude Paroz Owned by: nobody
Component: Internationalization Version: 1.4-alpha-1
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In the new readonly password field widget in the admin User page, the displayed keys of the hasher are not translated. Working on a patch.

Attachments (1)

17457-1.diff (3.9 KB) - added by Claude Paroz 5 years ago.
Translate hasher keys in password widget

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by Claude Paroz

Attachment: 17457-1.diff added

Translate hasher keys in password widget

comment:1 Changed 5 years ago by Claude Paroz

Has patch: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

I'm unsure about tests. Are they needed her?

comment:2 Changed 5 years ago by Aymeric Augustin

In such cases, I don't believe tests are really useful. The chance of a regression is negligible, testing generated HTML is fragile, as is depending on .mo files. But I'm more laxist than other core devs in this area.

comment:3 Changed 5 years ago by Aymeric Augustin

Triage Stage: UnreviewedAccepted

comment:4 Changed 5 years ago by Ramiro Morales

Triage Stage: AcceptedReady for checkin

I agree with Aymeric.

comment:5 Changed 5 years ago by Aymeric Augustin

Resolution: fixed
Status: newclosed

In [17270]:

Fixed #17457 -- Marked strings used in hash descriptions for translation.

Note: See TracTickets for help on using tickets.
Back to Top