Opened 2 years ago

Closed 2 years ago

#17358 closed Cleanup/optimization (fixed)

Switch to arg-style logging instead of string interpolation

Reported by: spulec Owned by: nobody
Component: Core (Other) Version: 1.3
Severity: Normal Keywords: logging
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Change all logging from this

logger.warning("This is a %s" % var)


logger.warning("This is a %s", var)

Attachments (1)

update_logging_style_patch.diff (9.2 KB) - added by spulec 2 years ago.

Download all attachments as: .zip

Change History (4)

Changed 2 years ago by spulec

comment:1 Changed 2 years ago by aaugustin

  • Component changed from Uncategorized to Core (Other)
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 2 years ago by jezdez

  • Triage Stage changed from Accepted to Ready for checkin

comment:3 Changed 2 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

In [17480]:

Fixed #17358 -- Updated logging calls to use official syntax for arguments instead of string interpolation. Thanks, spulec.

Add Comment

Modify Ticket

Change Properties
<Author field>
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.