"View on site" link breaks when quote(object_id) != object_id

[David Chandek-Stark]

The change_view method of django.contrib.admin.options.ModelAdmin returns object_id as passed in. This means that the "View on site" link breaks in cases where the django.contrib.admin.util.quote(object_id) != object_id.

There are two possible solutions:
1) Call django.contrib.admin.util.unquote() on object_id before returning to change_view template;
2) Call django.contrib.admin.util.unquote() on object_id in django.contrib.contenttypes.views.shortcut in this line: obj = content_type.get_object_for_this_type(pk=object_id).

Attached are svn diffs for each.

[Julien Phalip]

Solution 1) is the right one. Could you provide a test case? Thanks!

[David Chandek-Stark]

Replying to julien:

Solution 1) is the right one. Could you provide a test case? Thanks!

Happy to take a crack at a test case. Since I've not contributed one to Django before, I'm not sure the more helpful way to do this. My first guess is to write a test_viewonsite_link method in the AdminViewStringPrimaryKeyTest class of tests/regressiontests/admin_views/tests.py.

[David Chandek-Stark]

Initial attempt at patch + unit test. Note that i18n not applied to "View on site" in test.

[David Chandek-Stark]

I realized that the new test could just be added to the test_get_change_view() method. As noted, i18n may need to be applied to "View on site" text in test.

[Claude Paroz]

I guess that this issue might have been fixed along #18444. Can someone confirm?

[Ludovic Delaveau]

I have the feeling that the test test_shortcut_view_with_escaping at line 1453 in tests/regressiontests/admin_views/tests.py confirms that the issue is fixed:

def test_shortcut_view_with_escaping(self):                                                              
    "'View on site should' work properly with char fields"                                               
    model = ModelWithStringPrimaryKey(pk='abc_123')                                                      
    model.save()                                                                                         
    response = self.client.get('/test_admin/admin/admin_views/modelwithstringprimarykey/%s/' % quote(model.pk))                                                                                                        
    should_contain = '/%s/" class="viewsitelink">' % model.pk                                            
    self.assertContains(response, should_contain)                                                        

[Claude Paroz]

OK, let's consider it fixed.