Opened 5 years ago

Closed 5 years ago

#17150 closed Cleanup/optimization (fixed)

NamedUrlWizardView should add 'url_name' to wizard object in template context

Reported by: Bradley Ayers <bradley.ayers@…> Owned by: nobody
Component: contrib.formtools Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no


Currently there's no way to access the URL name used to create 'step' URLs with the NamedUrlWizardView. I propose that NamedUrlWizardView should implement get_context_data, and add 'url_name' to the 'wizard' dict.

Attachments (1)

trac-17150.diff (1.6 KB) - added by steph 5 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by Julien Phalip

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 5 years ago by Jannis Leidel

Yeah, sounds reasonable.

Changed 5 years ago by steph

Attachment: trac-17150.diff added

comment:3 Changed 5 years ago by steph

I added a patch with extended template context for namedurlwizardview. I think this is ready for checkin.

comment:4 Changed 5 years ago by Julien Phalip

Needs tests: set

That looks pretty good. Could you please also add a test for this?

comment:5 Changed 5 years ago by Julien Phalip

Needs tests: unset

Sorry, I missed the fact there was already a test ;)

comment:6 Changed 5 years ago by Julien Phalip

Resolution: fixed
Status: newclosed

In [17232]:

Fixed #17150 -- Made NamedUrlWizardView.url_name available in the template context. Thanks to Bradley Ayers for the suggestion and to Stephan Jaekel for the patch.

Note: See TracTickets for help on using tickets.
Back to Top