Opened 13 years ago

Closed 11 years ago

#17149 closed Cleanup/optimization (fixed)

MediaDefiningClass not used as base class for other form meta classes

Reported by: bradley.ayers@… Owned by: nobody
Component: Forms Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I think django.forms.widgets.MediaDefiningClass should be a base class for django.forms.forms.DeclarativeFieldsMetaclass and django.forms.models.ModelFormMetaclass

Change History (2)

comment:1 by Aymeric Augustin, 13 years ago

Triage Stage: Unreviewed → Accepted

This code is duplicated in the __new__ method of these classes:

        if 'media' not in attrs:
            new_class.media = media_property(new_class)

comment:2 by Claude Paroz, 11 years ago

Resolution: → fixed
Status: new → closed

Fixed by [ac5ec7b8bcc5623cc05d4df900c39e194f5affcf].

Note: See TracTickets for help on using tickets.
Back to Top