Opened 12 years ago
Closed 11 years ago
#17149 closed Cleanup/optimization (fixed)
MediaDefiningClass not used as base class for other form meta classes
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | Forms | Version: | 1.3 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I think django.forms.widgets.MediaDefiningClass should be a base class for django.forms.forms.DeclarativeFieldsMetaclass and django.forms.models.ModelFormMetaclass
Change History (2)
comment:1 by , 12 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
This code is duplicated in the
__new__method of these classes:if 'media' not in attrs: new_class.media = media_property(new_class)