Python 2.5-incompatible change in r16319 -- ModelAdmin.list_display.index method called
|Reported by:||Simon Meers||Owned by:||Simon Meers|
|Severity:||Normal||Keywords:||python 2.5, tuple, index, list_display|
|Cc:||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
r16319 introduced a python 2.5-incompatible change in which
index method is called despite the fact that it is likely a tuple (which only has an
index method in 2.6+).
I imagine this managed to hide for so long because:
- No tests failed -- some use lists for list_display, and most don't have
orderingset on the
ChangeListsfor which actions were present (which they are by default) have their
action_checkboxis prepended (bypassed if rendering the
- The number of people using Django trunk with Python 2.5 are no doubt a minority
I've attached a patch which addresses the issue and includes regression tests, which I'll commit unless someone thinks it could be done better.