id,summary,reporter,owner,description,type,status,component,version,severity,resolution,keywords,cc,stage,has_patch,needs_docs,needs_tests,needs_better_patch,easy,ui_ux 17128,Python 2.5-incompatible change in r16319 -- ModelAdmin.list_display.index method called,Simon Meers,Simon Meers,"r16319 introduced a python 2.5-incompatible change in which `ModelAdmin.list_display`'s `index` method is called despite the fact that it is likely a tuple (which only has an `index` method in 2.6+). I imagine this managed to hide for so long because: * No tests failed -- some use lists for list_display, and most don't have `ordering` set on the `ModelAdmin` or `Model.Meta` * `ChangeLists` for which actions were present (which they are by default) have their `list_display` listified when `action_checkbox` is prepended (bypassed if rendering the `result_list` without using `changelist_view`) * The number of people using Django trunk with Python 2.5 are no doubt a minority I've attached a patch which addresses the issue and includes regression tests, which I'll commit unless someone thinks it could be done better.",Bug,closed,contrib.admin,dev,Normal,fixed,"python 2.5, tuple, index, list_display",,Ready for checkin,1,0,0,0,0,0