Opened 5 years ago

Closed 5 years ago

#17119 closed Bug (fixed)

Cache Framework: wrong per-site cache behavior documentation

Reported by: Vanni Owned by: Dan Poirier
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

From ​https://docs.djangoproject.com/en/dev/topics/cache/#the-per-site-cache documentation page: "The cache middleware caches every page that doesn't have GET or POST parameters".
AFAIK it is not true. URLs with GET parameters (like ​http://www.example.com/?this_is_a_get_param=value) get (IMHO correctly) cached and POST parameters are simply ignored.

Attachments (1)

17119.diff​ (2.0 KB) - added by Calvin Spealman 5 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by vanni.totaro@…

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 5 years ago by vanni.totaro@…

Type: Uncategorized → Bug

comment:3 Changed 5 years ago by vanni.totaro@…

Easy pickings: set

comment:4 Changed 5 years ago by Dan Poirier

Owner: changed from nobody to Dan Poirier
Triage Stage: Unreviewed → Accepted

Looking at the cache code, doc is clearly wrong.

Changed 5 years ago by Calvin Spealman

Attachment: 17119.diff​ added

comment:6 Changed 5 years ago by Karen Tracey

Resolution: → fixed
Status: new → closed

In [17090]:

Fix #17119: Update cache doc to match current implementation, which does (since r15705) cache pages with GET parameters. Thanks Vanni, poirier, and calvinspealman.

Note: See TracTickets for help on using tickets.
Back to Top