Code

Opened 2 years ago

Closed 2 years ago

#17119 closed Bug (fixed)

Cache Framework: wrong per-site cache behavior documentation

Reported by: Vanni Owned by: poirier
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

From ​https://docs.djangoproject.com/en/dev/topics/cache/#the-per-site-cache documentation page: "The cache middleware caches every page that doesn't have GET or POST parameters".
AFAIK it is not true. URLs with GET parameters (like ​http://www.example.com/?this_is_a_get_param=value) get (IMHO correctly) cached and POST parameters are simply ignored.

Attachments (1)

17119.diff​ (2.0 KB) - added by calvinspealman 2 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 2 years ago by vanni.totaro@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 2 years ago by vanni.totaro@…

  • Type changed from Uncategorized to Bug

comment:3 Changed 2 years ago by vanni.totaro@…

  • Easy pickings set

comment:4 Changed 2 years ago by poirier

  • Owner changed from nobody to poirier
  • Triage Stage changed from Unreviewed to Accepted

Looking at the cache code, doc is clearly wrong.

Changed 2 years ago by calvinspealman

comment:6 Changed 2 years ago by kmtracey

  • Resolution set to fixed
  • Status changed from new to closed

In [17090]:

Fix #17119: Update cache doc to match current implementation, which does (since r15705) cache pages with GET parameters. Thanks Vanni, poirier, and calvinspealman.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.