Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#17053 closed Cleanup/optimization (fixed)

Add a note about USE_THOUSAND_SEPARATOR in localization docs

Reported by: shelldweller Owned by: nobody
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: shelldweller Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

I've had a bit of a difficult time figuring out why my numbers did not localize with thousand separator in templates. After poking around I've found my way around. I would like to add little clarification to the docs summarizing my findings.

Attachments (2)

localization-doc-patch.diff (954 bytes) - added by shelldweller 5 years ago.
formatting.txt.patch (840 bytes) - added by shelldweller 5 years ago.
New patch because doc structure has changed.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by shelldweller

Attachment: localization-doc-patch.diff added

comment:1 Changed 5 years ago by shelldweller

Cc: shelldweller added
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 5 years ago by Claude Paroz

Triage Stage: UnreviewedAccepted

comment:3 Changed 5 years ago by Dan Poirier

Patch needs improvement: set

The patch does not apply, it looks as if the localization docs were re-arranged in [17026].

comment:4 Changed 5 years ago by Christopher Medrela

Resolution: fixed
Status: newclosed

I've closed this ticket because there is proper annotation on https://docs.djangoproject.com/en/1.3/topics/i18n/localization/#creating-custom-format-files.

comment:5 Changed 5 years ago by shelldweller

Patch needs improvement: unset
Resolution: fixed
Status: closedreopened

The link above tell us how to apply custom formats. My patch was about enabling thousand separator. From the docs it looks like simply setting USE_L10N should do the trick. However this is not enough to trigger number formatting with thousand separator.

Adding new patch.

Changed 5 years ago by shelldweller

Attachment: formatting.txt.patch added

New patch because doc structure has changed.

comment:6 Changed 4 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: reopenedclosed

In [4f3a6b853a6160a9f96d0b73199524a9bb062f90]:

Fixed #17053 - Added a note about USE_THOUSAND_SEPARATOR setting to localizations docs.

Thanks shelldweller for the draft patch.

comment:7 Changed 4 years ago by Tim Graham <timograham@…>

In [6536f7597b4cbccc53846d099fbc7a6b13929ab7]:

[1.4.X] Fixed #17053 - Added a note about USE_THOUSAND_SEPARATOR setting to localizations docs.

Thanks shelldweller for the draft patch.
Backport of 4f3a6b853a from master

Note: See TracTickets for help on using tickets.
Back to Top