Opened 3 years ago

Closed 3 years ago

#16960 closed New feature (duplicate)

Refactor d.u.translations.trans_real to support xmb files, clean up code

Reported by: arb@… Owned by: nobody
Component: Internationalization Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Right now the .mo file support is baked in pretty deep to the translations stuff. It would be useful (to me, and I've seen other people out there talking as well) if it could support other formats, such as XMB/XTB format (http://cldr.unicode.org/development/development-process/design-proposals/xmb)

In addition, looking at the code in trans_real.py it's a bit nasty, with nested functions all over the place. It could do with a bit of a cleanup/refactor.

I'm most likely going to need to do this anyway, but if there's interest I can look at contributing the code back upstream.

Change History (4)

comment:1 Changed 3 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Just to clarify - I'm proposing to refactor the code to clean it up and make it so you can supply pluggable translation engines.

comment:2 Changed 3 years ago by jezdez

  • Component changed from Uncategorized to Internationalization
  • Triage Stage changed from Unreviewed to Design decision needed

While I appreciate the gesture, this is a rather big proposal and needs a bit more clarification than what you provided in the ticket description. As this is more than a refactor (but an actual feature addition) I'd like to encourage you to follow our contribution policy and send a detailed proposal to the django-developers list.

Marking as design decision needed for now..

comment:3 Changed 3 years ago by ramiro

Proposal of this ticket possibly related to the one in #14974.

comment:4 Changed 3 years ago by aaugustin

  • Resolution set to duplicate
  • Status changed from new to closed

I just requalified the scope of #14974. As a consequence, this ticket is now a duplicate.

Note: See TracTickets for help on using tickets.
Back to Top