Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#16904 closed Cleanup/optimization (fixed)

django.contrib.messages minor note

Reported by: murphyke Owned by: nobody
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In the "Displaying messages" section, it might be helpful to add the sentence: "Even when you know there is only just one message, you should still iterate over the messages sequence, because otherwise the message storage will not be cleared for the next request."

The patch is attached.

Attachments (1)

messages.txt.diff (576 bytes) - added by murphyke 4 years ago.

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by murphyke

comment:1 Changed 4 years ago by aaugustin

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin
  • Type changed from Uncategorized to Cleanup/optimization

comment:2 Changed 4 years ago by DrMeers

  • Resolution set to fixed
  • Status changed from new to closed

In [16866]:

Fixed #16904 -- Additional clarification regarding contrib.messages iteration. Thanks murphyke for the report and patch.

comment:3 Changed 4 years ago by DrMeers

In [16867]:

[1.3.X] Fixed #16904 -- Additional clarification regarding contrib.messages iteration. Thanks murphyke for the report and patch.

Backport of [16866] from trunk.

Note: See TracTickets for help on using tickets.
Back to Top