Add '--no-location' option for 'makemessages' command

[Alpár Jüttner]

The attached patch adds a --no-location option for the makemessages management command. It is against svn trunk revision -r16861. Please consider adding it to the svn repo.

Rational: Location comments in the .po files can are very annoying when they are version controlled, because changes in the source codes will trigger a lot of changes in the .po files, even when the strings to be translated are not affected. The obvious remedy for this is using --no-location.

[Aymeric Augustin]

It would be nice to add a test in tests/regressiontests/i18n/commands.

[Alpár Jüttner]

A novice question. Assume I have a sole checkout of django svn trunk. What is the easiest way to run its tests? (All of them, or just a specific one, such as NoWrapExtractorTests).

[Aymeric Augustin]

The fastest way to run all the tests is:

% cd tests
% PYTHONPATH=.. python runtests.py --settings=test_sqlite

That will take some time, because there are more than 4000 tests. You can find more details — in particular, how to run a subset of the tests — in the contributing guide: ​https://docs.djangoproject.com/en/1.3/internals/contributing/#running-the-unit-tests

[Alpár Jüttner]

Tests added

[Alpár Jüttner]

Replying to aaugustin:

It would be nice to add a test in tests/regressiontests/i18n/commands.

The newly attached patch​ also performs some basic tests. Let me know if this is sufficient or not.

(Thanks for the help on testing.)

[Alpár Jüttner]

Is there anything to do for me in order to get this patch merged into the svn version?

[Julien Phalip]

The patch and tests look good. One note though: the tests currently can be running until you import NoLocationExtractorTests in regressiontests.i18n.tests.py under the if can_run_extraction_tests condition. Could you also update the test method names to test_location_enabled() and test_location_disabled().

Finally, some documentation should be added for this new option: ​https://docs.djangoproject.com/en/dev/ref/django-admin/#makemessages

Thanks for the great work!

[Alpár Jüttner]

Fix tests, add docs

[Alpár Jüttner]

Please find the revised patch​ attached.
Changes compared to the previous version:

• Doc added to docs/ref/django-admin.txt
• Import NoLocationExtractorTests from tests/regressiontests/i18n/tests.py
• Change the test function names to the suggested ones.

[Julien Phalip]

Looks great, thank you!

[Julien Phalip]

In [17081]:

Fixed #16903 -- Added --no-location option to the makemessages command to not write '#: filename:line' comment lines in language files. Thanks to alpar for the suggestion and patch.

[Ramiro Morales <ramiro@…>]

In 4b715fc05a75c375d5afe1860ce748ae2a2e290b:

Fixed #21209 -- .po file path comments on Windows.

Literals from source files with Django template language syntax don't
have a '.py' suffix anymore.

Also, the '.\' prefix is preserved to respect GNU gettext behavior on
that platform.

Refs #16903.

[Ramiro Morales <ramiro@…>]

In d16753eecd3c97c781382fbb4c119f6bae314487:

[1.6.x] Fixed #21209 -- .po file path comments on Windows.

Literals from source files with Django template language syntax don't
have a '.py' suffix anymore.

Also, the '.\' prefix is preserved to respect GNU gettext behavior on
that platform.

Refs #16903.

4b715fc05a from master.