RedirectView (class based) query string format bug

[Sławek Ehlert]

There is a problem with the new class based RedirectView with query_string = True and some unicode string in QUERY_STRING.
I made a sample of the error on bitbucket

​https://bitbucket.org/slafs/redirectviewtest/src

The error that I'm getting is :

 File "/usr/local/lib/python2.7/dist-packages/django/views/generic/base.py" in get_redirect_url
 146.             return url % kwargs

 Exception Type: ValueError at /test/
 Exception Value: unsupported format character 'C' (0x43) at index 15

Basically the problem is when a QUERY_STRING contains some unicode chars that were previously encoded with urlencode (i.e. {{ request.GET.urlencode }} - like in my bitbucket example ) and for example polish "ż" is encoded as "%C5" which breaks the "%" formatting.

The relevant topic on Google Groups is here ​https://groups.google.com/d/topic/django-users/L0hkxuyUt4U/discussion

As Karen M. Tracey suggested I opened this ticket.

[Alexey Smolsky]

I think kwargs should be applied before concatenation with query string. Patch attached.

[jamey@…]

I believe accuser's patch is the correct fix for this bug, which I just ran into. I hope it will be included in 1.4, though I'd also like a stable release on the 1.3 series to include this patch and the fix for #15852.

[Aymeric Augustin]

Currently, this patch needs tests, which prevents it from being committed.

[jamey@…]

OK, I've added a test case to accuser's patch, which fails without the patch and passes with it. Good enough?

[Claude Paroz]

Patch updated to current trunk

[Claude Paroz]

The patch could not be applied to trunk. The part about the function-based generic view "redirect_to" has been fixed in r17034. Just uploaded a new patch with that part removed.

[Jannis Leidel]

In [17625]:

Fixed #16842 -- Modified the RedirectView to correctly handle query strings with percent symbols. Thanks, accuser, jamey@… and Claude Paroz.