Opened 13 years ago
Closed 12 years ago
#16777 closed Cleanup/optimization (invalid)
Contributing guide: github and bitbucket pull requests are acceptable
Reported by: | Aymeric Augustin | Owned by: | Justin Lilly |
---|---|---|---|
Component: | Documentation | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | yes | UI/UX: | no |
Description
See Russell's comment here: https://code.djangoproject.com/ticket/16774#comment:2
I'm pretty sure this isn't written in the current documentation.
Change History (14)
comment:1 by , 13 years ago
comment:2 by , 13 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 13 years ago
Note, a Trac ticket is still needed for pull requests to get attention from the core team. They are only other forms of patches, rather than tickets.
comment:4 by , 13 years ago
See also #16779, which is essentially different but potentially has some overlap with this ticket.
comment:5 by , 13 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:7 by , 13 years ago
Would clarify "will likely" to "discussion should be continued" to make clear that trac is where all discussion should happen. Also need to update https://code.djangoproject.com/wiki/CollaborateOnGithub
comment:8 by , 13 years ago
Patch needs improvement: | set |
---|
And while you are at it, give GitHub and Bitbucket a few capital letters to reflect their brand names :-)
comment:9 by , 13 years ago
Patch needs improvement: | unset |
---|
Updated. Same link as before, wiki was also updated.
comment:10 by , 13 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
comment:11 by , 13 years ago
Patch needs improvement: | set |
---|---|
Triage Stage: | Ready for checkin → Accepted |
This needs a bit fat warning in the first paragraph that a Trac ticket is still needed.
comment:13 by , 12 years ago
Link to pull request now refers to a completely different issue after the github move...
comment:14 by , 12 years ago
Resolution: | → invalid |
---|---|
Status: | assigned → closed |
Indeed, this ticket no longer makes sense now that we've moved to GitHub. We are going to write some GitHub guidelines (eventually). I'm not sure BitBucket pull requests will be accepted.
And explain how to download the diff, that's what triggers and core developers need most.