Opened 4 years ago

Closed 3 years ago

#16777 closed Cleanup/optimization (invalid)

Contributing guide: github and bitbucket pull requests are acceptable

Reported by: aaugustin Owned by: justinlilly
Component: Documentation Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: yes UI/UX: no

Description

See Russell's comment here: https://code.djangoproject.com/ticket/16774#comment:2

I'm pretty sure this isn't written in the current documentation.

Change History (14)

comment:1 Changed 4 years ago by aaugustin

And explain how to download the diff, that's what triggers and core developers need most.

comment:2 Changed 4 years ago by julien

  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 4 years ago by jezdez

Note, a Trac ticket is still needed for pull requests to get attention from the core team. They are only other forms of patches, rather than tickets.

comment:4 Changed 4 years ago by julien

See also #16779, which is essentially different but potentially has some overlap with this ticket.

Last edited 4 years ago by julien (previous) (diff)

comment:5 Changed 4 years ago by justinlilly

  • Owner changed from nobody to justinlilly
  • Status changed from new to assigned

comment:6 Changed 4 years ago by justinlilly

  • Has patch set

First pass at the documentation.

https://github.com/django/django/pull/42

comment:7 Changed 4 years ago by ptone

Would clarify "will likely" to "discussion should be continued" to make clear that trac is where all discussion should happen. Also need to update https://code.djangoproject.com/wiki/CollaborateOnGithub

comment:8 Changed 4 years ago by bpeschier

  • Patch needs improvement set

And while you are at it, give GitHub and Bitbucket a few capital letters to reflect their brand names :-)

comment:9 Changed 3 years ago by justinlilly

  • Patch needs improvement unset

Updated. Same link as before, wiki was also updated.

comment:10 Changed 3 years ago by bpeschier

  • Triage Stage changed from Accepted to Ready for checkin

comment:11 Changed 3 years ago by jezdez

  • Patch needs improvement set
  • Triage Stage changed from Ready for checkin to Accepted

This needs a bit fat warning in the first paragraph that a Trac ticket is still needed.

comment:12 Changed 3 years ago by justinlilly

Updated.

comment:13 Changed 3 years ago by mjtamlyn

Link to pull request now refers to a completely different issue after the github move...

comment:14 Changed 3 years ago by aaugustin

  • Resolution set to invalid
  • Status changed from assigned to closed

Indeed, this ticket no longer makes sense now that we've moved to GitHub. We are going to write some GitHub guidelines (eventually). I'm not sure BitBucket pull requests will be accepted.

Note: See TracTickets for help on using tickets.
Back to Top