inspectdb with numerical column names

[danodonovan]

inspectdb produces model fields with numerical values for fieldnames when running with a (MySQL at least) DB with numerical column labels. For example, sql with column names 1 and 2 results in invalid python code:

    1 = models.CharField()
    2 = models.CharField()

I would submit a patch, but I don't want to suggest a default prefix name for these fields without advice. Would suggest 'number_%d' % db_column or similar.

[Aymeric Augustin]

This problem is similar to the situation when a database column name is a Python reserved word (such as 'pass', 'class' or 'for'). In such cases, inspectdb appends '_field' to the column name.

'number_%d' sounds OK to me.

Could you also add a comment in the generated code: "'Field renamed because it wasn't a valid Python identifier."?

Patch appreciated :)

[teraom]

1. Is the usage of isdigit() correct here? I assume there will be no period in the column name.
2. Should I use unicode.isnumeric() instead?

[danodonovan]

Thanks teraom! Unfortunately there is more trickyness: As the column name has changed, we should add

     extra_params['db_column'] = unicode(column_name)

Without that unicode casting, my test db wasn't recognising db_column as being valid (they returned nothing).

att_name isn't a digit in python world so maybe we should do:

    att_name = 'number_%d' % int(att_name)

Revised patch attached. Dan

[danodonovan]

ammended patch

[Malcolm Tredinnick]

In [16641]:

Teach inspectdb to handle SQL column names that are digits.

There's no accounting for taste in the way some people name columns,
apparently. Create a column with a name of "1" and inspectdb will still
produce valid Python code now. Fixed #16536. Thanks tereaom and
danodonovan.