Opened 4 years ago

Closed 4 years ago

#16523 closed Bug (fixed)

manage.py's runserver autoreloading is broken in Jython

Reported by: rudd@… Owned by: nobody
Component: Core (Management commands) Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Currently, because Jython files are compiled to have the suffix $py.class, and these are the files referenced in Jython, changes to the original source files aren't picked up by the Django autoreloader.

I have a fix in a pull request on the Github mirror: https://github.com/django/django/pull/28

Attachments (1)

16523.diff (658 bytes) - added by aaugustin 4 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 4 years ago by aaugustin

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

We already have a comparable Jython-specific fix here:
https://code.djangoproject.com/browser/django/trunk/django/core/management/__init__.py#L406

I'm attaching the patch from the pull request. It looks good to me; the only reason why I don't mark it as RFC is that I don't have access to a Jython installation to test it.

Changed 4 years ago by aaugustin

comment:2 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

In [16619]:

Fixed #16523 -- Made path handling in autoreload code work on Jython. Thanks, Aymeric Augustin.

Note: See TracTickets for help on using tickets.
Back to Top