Code

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1643 closed defect (fixed)

Generic views need to be updated for template extension change

Reported by: Esaj Owned by: jacob
Component: Generic views Version: magic-removal
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description


Attachments (0)

Change History (5)

comment:1 Changed 8 years ago by Esaj

Also, the 404 and 500 templates should probably be loaded from 404.html and 500.html. That is, unless people think generic view and error templates should just have no extensions...

comment:2 Changed 8 years ago by lukeplant

As well as updates to the generic views, I think the magic removal migration docs should have a note saying that the 'template_name' parameter to generic views needs updating -- in the common case this will require updating urls.py

comment:3 Changed 8 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [2701]) magic-removal: Fixed #1643 -- Updated generic views for template extension change

comment:4 Changed 8 years ago by adrian

(In [2703]) magic-removal: Changed 404 and 500 templates to add .html extension. Refs #1643

comment:5 Changed 8 years ago by adrian

I've updated RemovingTheMagic to mention the generic-views template_name change.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.