Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1643 closed defect (fixed)

Generic views need to be updated for template extension change

Reported by: Esaj Owned by: Jacob
Component: Generic views Version: magic-removal
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Change History (5)

comment:1 Changed 12 years ago by Esaj

Also, the 404 and 500 templates should probably be loaded from 404.html and 500.html. That is, unless people think generic view and error templates should just have no extensions...

comment:2 Changed 12 years ago by Luke Plant

As well as updates to the generic views, I think the magic removal migration docs should have a note saying that the 'template_name' parameter to generic views needs updating -- in the common case this will require updating

comment:3 Changed 12 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [2701]) magic-removal: Fixed #1643 -- Updated generic views for template extension change

comment:4 Changed 12 years ago by Adrian Holovaty

(In [2703]) magic-removal: Changed 404 and 500 templates to add .html extension. Refs #1643

comment:5 Changed 12 years ago by Adrian Holovaty

I've updated RemovingTheMagic to mention the generic-views template_name change.

Note: See TracTickets for help on using tickets.
Back to Top