urlize works with malformed URLs

[Bernhard Essl]

I think the template filter urlize should not return broken URLs as clickable links.

In [1]: from django.template.defaultfilters import urlize

In [2]: urlize("http://:/:/.foo.com")
Out[2]: u'<a href="http://:/:/.foo.com" rel="nofollow">http://:/:/.foo.com</a>'

I added a patch and a testcase for it.

[Aymeric Augustin]

Your patch is basically checking that http:// is followed by a word character; could you explain why this is the right thing to do? IMO, validation must be implemented correctly or not at all.

Regarding the patch, I think it would be much clearer to structure the code like this:

if middle.startswith('http://') or middle.startswith('https://'):
    # do additional checks, and set url only if the checks pass
elif ... # unchanged

It's more readable than adding not middle.startswith('http') to every subsequent condition — since you only added it to the first one, I think ​http:////@foo.com will be misinterpreted as an email. (By the way, Trac happily turns that into an HTTP link).

[Bernhard Essl]

Thanks aaugustin for the input. I updated the patch. hihi @trac

[Aymeric Augustin]

In [17358]:

(The changeset message doesn't reference this ticket)