Opened 13 years ago

Closed 13 years ago

#16394 closed Bug (fixed)

BaseDateListView has allow_empty = False, documentation claims allow_empty = True

Reported by: r.tirrell@… Owned by: nobody
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The docs state clearly that allow_empty on BaseDateListView defaults to True, which is at odds with what seems to be the case in the source. I noticed this because the ... and not qs in BaseDateListView's get_dated_queryset was causing a full SELECT over the entire table.

Attachments (1)

16394.diff​ (741 bytes ) - added by Aymeric Augustin 13 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 by Aymeric Augustin, 13 years ago

Has patch: set
Triage Stage: Unreviewed → Accepted

by Aymeric Augustin, 13 years ago

Attachment: 16394.diff​ added

comment:2 by Julien Phalip, 13 years ago

Triage Stage: Accepted → Ready for checkin

comment:3 by Jannis Leidel, 13 years ago

Resolution: → fixed
Status: new → closed

In [16566]:

Fixed #16394 -- Corrected documentation of the allow_empty option of the BaseDateListView view. Thanks, Aymeric Augustin.

Note: See TracTickets for help on using tickets.
Back to Top