Opened 5 years ago

Closed 5 years ago

#16394 closed Bug (fixed)

BaseDateListView has allow_empty = False, documentation claims allow_empty = True

Reported by: r.tirrell@… Owned by: nobody
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no


The docs state clearly that allow_empty on BaseDateListView defaults to True, which is at odds with what seems to be the case in the source. I noticed this because the ... and not qs in BaseDateListView's get_dated_queryset was causing a full SELECT over the entire table.

Attachments (1)

16394.diff (741 bytes) - added by Aymeric Augustin 5 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 5 years ago by Aymeric Augustin

Has patch: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

Changed 5 years ago by Aymeric Augustin

Attachment: 16394.diff added

comment:2 Changed 5 years ago by Julien Phalip

Triage Stage: AcceptedReady for checkin

comment:3 Changed 5 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

In [16566]:

Fixed #16394 -- Corrected documentation of the allow_empty option of the BaseDateListView view. Thanks, Aymeric Augustin.

Note: See TracTickets for help on using tickets.
Back to Top