Opened 14 years ago

Closed 14 years ago

#16222 closed Bug (fixed)

Tests failing since Revision 16356

Reported by: Vasil Vangelovski Owned by: nobody
Component: Uncategorized Version: dev
Severity: Normal Keywords:
Cc: gandalf@…, zerok@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The testcase in contrib.formtools.wizard is failing since 16356 which is fixing Ticket #16182

Traceback (most recent call last):
  File ".../django-source/django/contrib/formtools/wizard/tests/cookiestoragetests.py", line 38, in test_reset_cookie
    self.assertEqual(response.cookies[storage.prefix].value, signed_cookie_data)
AssertionError: '{"key1":"value1"}:3iEGhRxR:tOAVBIdA8Zn6yntbOeqF0tr59Bg' != '{"key1":"value1"}:3iEGhRxS:228hK_rvMcdUO-sx_fUrS9YheP8'

Attachments (1)

ticket16222.diff (1.6 KB ) - added by Jure Cuhalev <gandalf@…> 14 years ago.
Test was failing because of the race condition that occurred now that there's a higher time precision. Fixed the test to check unsigned values and added additional asserts so that max_age condition gets checked.

Download all attachments as: .zip

Change History (6)

comment:1 by Jure Cuhalev <gandalf@…>, 14 years ago

Cc: gandalf@… added

comment:2 by Horst Gutmann <zerok@…>, 14 years ago

Cc: zerok@… added
Triage Stage: UnreviewedAccepted

by Jure Cuhalev <gandalf@…>, 14 years ago

Attachment: ticket16222.diff added

Test was failing because of the race condition that occurred now that there's a higher time precision. Fixed the test to check unsigned values and added additional asserts so that max_age condition gets checked.

comment:3 by Jure Cuhalev <gandalf@…>, 14 years ago

Has patch: set

comment:4 by Andrew Godwin, 14 years ago

Triage Stage: AcceptedReady for checkin

comment:5 by Andrew Godwin, 14 years ago

Resolution: fixed
Status: newclosed

In [16376]:

Fixed #16222: Test failures due to more precise cookie timings. Refs [16356].

Note: See TracTickets for help on using tickets.
Back to Top