Opened 4 years ago

Closed 4 years ago

#16198 closed Cleanup/optimization (fixed)

model_forms tests are still doctests.

Reported by: gregmuellegger Owned by: nobody
Component: Testing framework Version: 1.3
Severity: Normal Keywords: model_forms, doctests
Cc: pterk Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Refactor model_forms tests to be unittests instead of doctests.

Attachments (2)

ticket16198_model_forms_test_refactoring.1.diff (121.4 KB) - added by gregmuellegger 4 years ago.
Sorry previous patch version was just plain wrong.
ticket16198_model_forms_test_refactoring.2.diff (121.7 KB) - added by gregmuellegger 4 years ago.
Added Peter van Kampen to AUTHORS file, he did most of the work. Thank you!

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by gregmuellegger

Sorry previous patch version was just plain wrong.

Changed 4 years ago by gregmuellegger

Added Peter van Kampen to AUTHORS file, he did most of the work. Thank you!

comment:1 Changed 4 years ago by pterk

  • Cc pterk added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 4 years ago by aaugustin

  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 4 years ago by melinath

  • Triage Stage changed from Accepted to Ready for checkin

Applies cleanly & tests pass. Yay!

comment:4 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

In [16358]:

Fixed #16198 -- Ported the model_forms doctests. Our long national nightmare is over. Oh, and we have always been at war with doctests. Thanks to Peter van Kampen and Gregor Müllegger for the patch.

Note: See TracTickets for help on using tickets.
Back to Top