Opened 13 years ago

Closed 13 years ago

#16198 closed Cleanup/optimization (fixed)

model_forms tests are still doctests.

Reported by: Gregor Müllegger Owned by: nobody
Component: Testing framework Version: 1.3
Severity: Normal Keywords: model_forms, doctests
Cc: Peter van Kampen Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Refactor model_forms tests to be unittests instead of doctests.

Attachments (2)

ticket16198_model_forms_test_refactoring.1.diff​ (121.4 KB ) - added by Gregor Müllegger 13 years ago.
Sorry previous patch version was just plain wrong.
ticket16198_model_forms_test_refactoring.2.diff​ (121.7 KB ) - added by Gregor Müllegger 13 years ago.
Added Peter van Kampen to AUTHORS file, he did most of the work. Thank you!

Download all attachments as: .zip

Change History (6)

by Gregor Müllegger, 13 years ago

Attachment: ticket16198_model_forms_test_refactoring.1.diff​ added

Sorry previous patch version was just plain wrong.

by Gregor Müllegger, 13 years ago

Attachment: ticket16198_model_forms_test_refactoring.2.diff​ added

Added Peter van Kampen to AUTHORS file, he did most of the work. Thank you!

comment:1 by Peter van Kampen, 13 years ago

Cc: Peter van Kampen added

comment:2 by Aymeric Augustin, 13 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Stephen Burrows, 13 years ago

Triage Stage: Accepted → Ready for checkin

Applies cleanly & tests pass. Yay!

comment:4 by Russell Keith-Magee, 13 years ago

Resolution: → fixed
Status: new → closed

In [16358]:

Fixed #16198 -- Ported the model_forms doctests. Our long national nightmare is over. Oh, and we have always been at war with doctests. Thanks to Peter van Kampen and Gregor Müllegger for the patch.

Note: See TracTickets for help on using tickets.
Back to Top