Tests with URLField(verify_exists=True) should use a mock and not access the internet directly.
|Reported by:||gregmuellegger||Owned by:||gregmuellegger|
|Cc:||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Currently the testsuite tries to hit some domains to test the verify_exists=True behaviour of URLFields. However unittests should not require any external resources.
urllib2.urlopen should be mocked in the tests to provide faster and more reliable tests.
Change History (5)
Changed 5 years ago by gregmuellegger
comment:1 Changed 5 years ago by nnrcschmdt
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
- Triage Stage changed from Unreviewed to Accepted