Code

Opened 3 years ago

Closed 3 years ago

#15838 closed New feature (fixed)

assertFieldOutput should be integrated to the general test framework

Reported by: julien Owned by: nobody
Component: Testing framework Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

assertFieldOutput is currently defined in source:django/trunk/tests/regressiontests/forms/localflavor/utils.py

This useful method is not localflavor-specific and it deserves to be integrated to the django.utils.unittest.TestCase class so that it can be used in other contexts.

By the way, I've also reported a bug with assertFieldOutput in #15805, and the patch attached to it contains tests for assertFieldOutput itself.

Attachments (1)

15838.1.2.diff (36.0 KB) - added by ramiro 3 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 3 years ago by aaugustin

  • Easy pickings unset
  • Triage Stage changed from Unreviewed to Accepted
  • Version changed from 1.2 to 1.3

comment:2 Changed 3 years ago by ramiro

  • Has patch set
  • UI/UX unset

Changed 3 years ago by ramiro

comment:3 Changed 3 years ago by julien

  • Triage Stage changed from Accepted to Ready for checkin

Awesome! Probably worth mentioning in the release notes too.

comment:4 Changed 3 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

In [16653]:

Fixed #15838 -- Promoted assertFieldOutput to a general test utility. Thanks to Ramiro Morales for the patch.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.