Opened 5 years ago

Closed 5 years ago

#15838 closed New feature (fixed)

assertFieldOutput should be integrated to the general test framework

Reported by: Julien Phalip Owned by: nobody
Component: Testing framework Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

assertFieldOutput is currently defined in source:django/trunk/tests/regressiontests/forms/localflavor/utils.py

This useful method is not localflavor-specific and it deserves to be integrated to the django.utils.unittest.TestCase class so that it can be used in other contexts.

By the way, I've also reported a bug with assertFieldOutput in #15805, and the patch attached to it contains tests for assertFieldOutput itself.

Attachments (1)

15838.1.2.diff (36.0 KB) - added by Ramiro Morales 5 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset
Triage Stage: UnreviewedAccepted
Version: 1.21.3

comment:2 Changed 5 years ago by Ramiro Morales

Has patch: set
UI/UX: unset

Changed 5 years ago by Ramiro Morales

Attachment: 15838.1.2.diff added

comment:3 Changed 5 years ago by Julien Phalip

Triage Stage: AcceptedReady for checkin

Awesome! Probably worth mentioning in the release notes too.

comment:4 Changed 5 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

In [16653]:

Fixed #15838 -- Promoted assertFieldOutput to a general test utility. Thanks to Ramiro Morales for the patch.

Note: See TracTickets for help on using tickets.
Back to Top