Lazy doesn't take into account methods defined in parents

[Amirouche]

Example:

from django.utils.datastructures import SortedDict
from django.utils.functional import lazy

def a(): return SortedDict([(2,2),(1,1)])

f = lazy(a, SortedDict)()
f[1]

This results in a TypeError

I got a patch ready but not sure if it does what it should do well since I don't grasp all the lazy functionality.

[Amirouche]

patch that deeply "copy" a class methods

[Amirouche]

added a test

[Luke Plant]

'deep copy' is confusing terminology - it normally refers to copy.deepcopy. What you are referring to is checking base class methods. The test name and comments need to be updated accordingly.

In addition, I think that test should not implicitly rely on the fact that SortedDict doesn't have __getitem__ defined - that could easily change. I would define a pair of custom classes that show the problem, probably within the test method itself.

Otherwise, this looks pretty good.

[Amirouche]

changed the test & added proper documentation

[Amirouche]

lastest version of the patch :)

[Luke Plant]

Thanks!

For future reference, when you have updated a patch, you should uncheck the 'Patch needs improvement' flag if you think the patch is up to scratch. A reviewer will set it again if it isn't.

[Luke Plant]

In [16157]:

Fixed #15811 - lazy() doesn't take into account methods defined in parents

Thanks to abki for the report and patch.

[Amirouche]

git format

[Amirouche]

new patch which avoids using double underscores.

[Luke Plant]

It's not at all obvious to me that this new patch does the same as the existing code, especially given the rather vague definition of 'dir': "return an alphabetized list of names comprising (some of) the attributes of the given object, and of attributes reachable from it."

So I'm closing again. Since the original bug is fixed, please open a new ticket or pull request for any cleanup.