Opened 13 years ago

Closed 12 years ago

#15700 closed Bug (duplicate)

Improve Internationalization docs

Reported by: Camilo Nova Owned by: nobody
Component: Documentation Version:
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Hi, the documentacion at:

http://docs.djangoproject.com/en/dev/topics/i18n/internationalization/#the-set-language-redirect-view

Needs to say that you need to have:

MIDDLEWARE_CLASSES = (
   ...
   'django.middleware.locale.LocaleMiddleware',
   ...
)

to work when you try to change your language, otherwise it will fail without a hint of the problem.

Also, there will be better that the view say something when this middleware is not set?

Attachments (1)

docs.diff (780 bytes ) - added by Camilo Nova 13 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 by Gabriel Hurley, 13 years ago

Triage Stage: UnreviewedAccepted

comment:2 by Luke Plant, 13 years ago

Type: Bug

comment:3 by Luke Plant, 13 years ago

Severity: Normal

comment:4 by Camilo Nova, 13 years ago

Easy pickings: unset

There is anything i can do to fix this soon?

comment:5 by Jacob, 13 years ago

If you produce a patch against the documentation that'll speed things up. Check out the contribution guide for an introduction to contributing if you need help on how to do that.

by Camilo Nova, 13 years ago

Attachment: docs.diff added

comment:6 by Camilo Nova, 13 years ago

Thanks Jacob, the patch is attached now.

comment:7 by Camilo Nova, 13 years ago

Has patch: set
Needs documentation: set

Any advance on this??

comment:8 by Luke Plant, 13 years ago

Needs documentation: unset
Patch needs improvement: set

Having looked at this, it seems like the docs for the set_language redirect view are just in the wrong place. That page is about i18n, and the set_language view is about controlling l10n. The correct place for those docs would probably be here: http://docs.djangoproject.com/en/dev/topics/i18n/deployment/#how-django-discovers-language-preference

And that page already has the information about the middleware.

comment:9 by Camilo Nova, 13 years ago

When it comes to implementation the first reference is http://docs.djangoproject.com/en/dev/topics/i18n/internationalization/#the-set-language-redirect-view and there is no information about this, so you think is better to have a link that references this page http://docs.djangoproject.com/en/dev/topics/i18n/deployment/#how-django-discovers-language-preference ??

comment:10 by Aymeric Augustin, 12 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:11 by Tim Graham, 12 years ago

Resolution: duplicate
Status: newclosed

Addressed in #17183

Note: See TracTickets for help on using tickets.
Back to Top