Code

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#17183 closed Cleanup/optimization (fixed)

i18n documentation: middleware not mentioned until very late

Reported by: anonymous Owned by: krzysiumed
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: krzysiumed@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In the documentation for i18n/l10n there is no mention of adding the 'django.middleware.locale.LocaleMiddleware' to the MIDDLEWARE_CLASSES setting until the third (and last) step of the documentation (https://docs.djangoproject.com/en/dev/topics/i18n/deployment/).

This is a little confusing for developers like me who like to jump right into things as soon as they have read the first part of the documentation (I do realize this may not be the best approach but believe me, I'm not the only one who does this). I think adding a small paragraph at the beginning of the i18n documentation (https://docs.djangoproject.com/en/dev/topics/i18n/translation/) about what is needed to get everything working would be beneficial.

Attachments (1)

17183.diff (749 bytes) - added by krzysiumed 3 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 3 years ago by stefan.freyr@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 3 years ago by stefan.freyr@…

  • Component changed from Uncategorized to Documentation
  • Type changed from Uncategorized to Cleanup/optimization

comment:3 Changed 3 years ago by aaugustin

  • Triage Stage changed from Unreviewed to Accepted

This problem is a consequence of the recent refactoring of the i18n docs.

Changed 3 years ago by krzysiumed

comment:4 Changed 3 years ago by krzysiumed

  • Has patch set
  • Owner changed from nobody to krzysiumed
  • Status changed from new to assigned

comment:5 Changed 3 years ago by krzysiumed

  • Cc krzysiumed@… added

comment:6 Changed 2 years ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In [b1f18e95a5481e582f52a42807506369b73d8c6a]:

Fixed #17183 - Added a note regarding LocaleMiddleware at the top of the i18n docs. Thanks krzysiumed for the patch.

comment:7 Changed 2 years ago by Tim Graham <timograham@…>

In [e4b7e7d86deb1303997d6c3b893c76ead2d6d46a]:

[1.4.X] Fixed #17183 - Added a note regarding LocaleMiddleware at the top of the i18n docs. Thanks krzysiumed for the patch.

Backport of b1f18e95a5 from master

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.