Opened 14 years ago
Closed 11 years ago
#15519 closed Bug (duplicate)
Custom SQL location
| Reported by: | Vlastimil Zíma | Owned by: | Vlastimil Zíma |
|---|---|---|---|
| Component: | Core (Management commands) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Location of directory with custom sql http://docs.djangoproject.com/en/dev/howto/initial-data/#initial-sql is different if models module is file or directory. This is similar to already fixed #6961.
I will attach a patch that should solve it.
Attachments (1)
Change History (9)
by , 14 years ago
| Attachment: | patch-15519.diff added |
|---|
comment:1 by , 14 years ago
| Severity: | → Normal |
|---|---|
| Type: | → Bug |
follow-up: 3 comment:2 by , 14 years ago
| Needs documentation: | set |
|---|---|
| Needs tests: | set |
| Triage Stage: | Unreviewed → Accepted |
comment:3 by , 14 years ago
Replying to jacob:
This is potentially backwards-incompatible, sadly -- if people have SQL in the (previously-incorrect) location it'll silently stop working. Not sure what the best approach here is, but we probably have to look in both places now.
This kind of backwards incompatible change was already done with fixtures location, but it does not mean it needs to be done the same way. Keep both places and mark old one as deprecated seems reasonable.
I can update patch if necessary.
comment:6 by , 12 years ago
Created a pull request on github: https://github.com/django/django/pull/747
comment:7 by , 12 years ago
| Has patch: | set |
|---|---|
| Needs tests: | unset |
| Owner: | changed from to |
| Status: | new → assigned |
| Version: | 1.2 → master |
Pull request is backward-compatible and contains tests. I am not sure about documentation.
comment:8 by , 11 years ago
| Resolution: | → duplicate |
|---|---|
| Status: | assigned → closed |
Duplicate of #14300 -- the patch there doesn't contain the code for backwards compatibility. It seems like it may be more trouble than it's worth, but I'd like a second opinion.
This is potentially backwards-incompatible, sadly -- if people have SQL in the (previously-incorrect) location it'll silently stop working. Not sure what the best approach here is, but we probably have to look in both places now.