TemplateDoesNotExist reports incorrect template during {% include %} from Class Based Views / TemplateResponse objects

[James Aylett]

If I have a django.views.generic.base.TemplateView as so:

from django.views.generic.base import TemplateView

class FailingView(TemplateView):
    template_name = 'outer.html'

with templates/outer.html being:

{% include "inner.html" %}

and templates/inner.html not existing, then the exception is:

TemplateDoesNotExist at /search/
outer.html

when it should be:

TemplateDoesNotExist at /search/
inner.html

This appears to be similar to #12787, but a test case similar to test_extends_include_missing_baseloader does not show up the problem, apparently because loader.get_template() will raise the correct exception, but loader.select_template() is used with a list or tuple inside SimpleTemplateResponse.resolve_template(), and gets this wrong.

[James Aylett]

Traceback of problem

[Russell Keith-Magee]

Valid problem, but not class-based view specific. As you've identified, the issue is with select_template(), which consumes the TemplateDoesNotExist error generated by the non-existence of inner.html, interprets that consumption as non-existence of the overall template, and then raises a new TemplateDoesNotExist exception because the list of provided template name (i.e., [outer.html]) couldn't be loaded.

[James Aylett]

Failing test

[Russell Keith-Magee]

#15510 is a duplicate, with a fairly complete analysis.

[Sam Thompson]

Fix added; fixed the test as well, which raised an exception due to r not being set when everything else was working great.

Also, I just realized I re-implemented the solution from #15510; but now we have a working test and a working patch in the same place at the same time.

[Russell Keith-Magee]

In [15717]:

Fixed #15502 -- Ensure that nested TemplateDoesNotExist errors are propegated with a meaningful error message when loaded using select_template. Thanks to jaylett for the report, and GDorn for the patch.

[Russell Keith-Magee]

In [15718]:

[1.2.X] Fixed #15502 -- Ensure that nested TemplateDoesNotExist errors are propegated with a meaningful error message when loaded using select_template. Thanks to jaylett for the report, and GDorn for the patch.

Backport of r15717 from trunk.

[Jacob]

Milestone 1.3 deleted