Code

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#15491 closed (fixed)

HTML syntax errors in contrib.comments templates

Reported by: jonathanslenders Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

<meta /> should be terminated by a slash. (XHTML doctype.)

<!-- --> should be placed around CSS when the CSS contains a less-than, greater-than or ampersand. (contains greater-than sign.)

Attachments (1)

patch3.patch (1.1 KB) - added by jonathanslenders 3 years ago.

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by jonathanslenders

comment:1 Changed 3 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

A CDATA block is a better approach to fixing this, but point taken.

comment:2 Changed 3 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

In [15642]:

Fixed #15491 -- Added a CDATA block and closed a stray tag in the comments HTML. Thanks to Jonathan Slenders for the report.

comment:3 Changed 3 years ago by russellm

In [15644]:

(The changeset message doesn't reference this ticket)

comment:4 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.