Code

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#15490 closed (fixed)

Some semicolons are missing in javascript code.

Reported by: jonathanslenders Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Several semicolons are missing in javascript code. (Statements need to be terminated by semicolons, even if browsers do not always require it.)

Attachments (1)

patch2.patch (1.7 KB) - added by jonathanslenders 3 years ago.

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by jonathanslenders

comment:1 Changed 3 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 follow-up: Changed 3 years ago by russellm

Thanks for the patch Jonathanl; for future reference, please generate diffs against the root of the source tree, so we don't have to go hunting to work out where the patch applies cleanly.

comment:3 Changed 3 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

In [15641]:

Fixed #15490 -- Added some missing semicolons in admin javascript. Thanks to Jonathan Slenders for the report and patch.

comment:4 Changed 3 years ago by russellm

In [15643]:

[1.2.X] Fixed #15490 -- Added some missing semicolons in admin javascript. Thanks to Jonathan Slenders for the report and patch.

Backport of r15641 from trunk.

comment:5 in reply to: ↑ 2 Changed 3 years ago by jonathanslenders

Replying to russellm:

Thanks for the patch Jonathanl; for future reference, please generate diffs against the root of the source tree, so we don't have to go hunting to work out where the patch applies cleanly.

Thanks for the tip, I'll do that next time.

comment:6 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.