Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#15349 closed (fixed)

Bound FormSet produces bound empty_form

Reported by: hidde-jan Owned by: nobody
Component: Forms Version: dev
Severity: Keywords: formset, is_bound, empty_form
Cc: carl.j.meyer@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The current implementation of BaseFormSet provides a method _get_empty_form. When a formset is bound, it supplies the data and files it received to the formclass. This results in the formset's empty_form being bound. This can lead to unexpected behaviour, especially when subclassing forms.Form.

The supplied patch has the fix and a test that checks wether the empty_form of a bound formset is still unbound.

Since the empty_form property was added for use as a template, there should be no difference, whatsoever, between the empty_form of a bound and an unbound formset.

Attachments (1)

unbound_empty_forms.diff​ (2.8 KB ) - added by hidde-jan 13 years ago.

Download all attachments as: .zip

Change History (5)

by hidde-jan, 13 years ago

Attachment: unbound_empty_forms.diff​ added

comment:1 by anonymous, 13 years ago

Version: 1.2 → SVN

comment:2 by Russell Keith-Magee, 13 years ago

Has patch: set
Triage Stage: Unreviewed → Ready for checkin

comment:3 by Luke Plant, 13 years ago

Resolution: → fixed
Status: new → closed

In [15614]:

Fixed #15349 - Bound FormSet produces bound empty_form

Thanks to hidde-jan for the report and patch.

comment:4 by Luke Plant, 13 years ago

In [15615]:

[1.2.X] Fixed #15349 - Bound FormSet produces bound empty_form

Thanks to hidde-jan for the report and patch.

Backport of [15614] from trunk.

Note: See TracTickets for help on using tickets.
Back to Top