Bound FormSet produces bound empty_form
|Reported by:||hidde-jan||Owned by:||nobody|
|Severity:||Keywords:||formset, is_bound, empty_form|
|Cc:||carl.j.meyer@…||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
The current implementation of BaseFormSet provides a method _get_empty_form. When a formset is bound, it supplies the data and files it received to the formclass. This results in the formset's empty_form being bound. This can lead to unexpected behaviour, especially when subclassing forms.Form.
The supplied patch has the fix and a test that checks wether the empty_form of a bound formset is still unbound.
Since the empty_form property was added for use as a template, there should be no difference, whatsoever, between the empty_form of a bound and an unbound formset.
Change History (5)
Changed 6 years ago by hidde-jan
comment:1 Changed 6 years ago by anonymous
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
- Version changed from 1.2 to SVN
comment:2 Changed 6 years ago by russellm
- Has patch set
- Triage Stage changed from Unreviewed to Ready for checkin
comment:3 Changed 6 years ago by lukeplant
- Resolution set to fixed
- Status changed from new to closed