#15024 closed (fixed)
The order of the list returned by django.utils.formats.get_format_modules changes since version 1.2.4
Reported by: | David Reynolds | Owned by: | nobody |
---|---|---|---|
Component: | Internationalization | Version: | 1.2 |
Severity: | Keywords: | blocker, regression | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
This manifests itself in the admin javascript date picker. The format for the date inserted by the 'Today' link changes every time I refresh the page.
If you look at the /admin/jsi18n/ URL and refresh it a few times you can see the formats varying on each refresh.
I have a fix, but I'm not sure if it is the best way to fix it (see attached patch)
VERSION: 1.2.4
Attachments (2)
Change History (10)
by , 14 years ago
Attachment: | format-module-ordering.diff added |
---|
comment:1 by , 14 years ago
Resolution: | → worksforme |
---|---|
Status: | new → closed |
I can't reproduce this, and I can't think of any obvious reason why formats would be in unpredictable order; to the best of my knowledge, they're always stored and retrieved in list/tuple order.
If you can provide more complete reproduction instructions (possibly a project that duplicates the problem), please reopen.
comment:2 by , 14 years ago
Resolution: | worksforme |
---|---|
Status: | closed → reopened |
I can recreate it with a new project in a clean virtualenv. I think the key to what makes it change is setting the LANGUAGE_CODE to 'en-gb' - could you try that on your setup and see if you can recreate it?
comment:3 by , 14 years ago
My guess would be the ordering of django.conf.locale.en_GB and django.conf.locale.en is changing
comment:4 by , 14 years ago
Component: | Uncategorized → Internationalization |
---|---|
Keywords: | blocker regression added |
milestone: | → 1.3 |
Triage Stage: | Unreviewed → Accepted |
Ok - confirmed with en_GB (i18n and l10n enabled); I couldn't reproduce with de_DE. It's also a regression from 1.2.3, making this a release blocker.
Still no idea why it would be happening, though...
by , 14 years ago
Attachment: | 15024.diff added |
---|
comment:5 by , 14 years ago
Has patch: | set |
---|
comment:6 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Initial patch