Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#15023 closed (fixed)

us_states.STATE_CHOICES, USPS_CHOICES should be tuples, not lists

Reported by: timo Owned by: nobody
Component: contrib.localflavor Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Since r15058 these lists are sorted but that makes them lists instead of tuples. To be backwards compatible and for consistency with the other choices, I think they should be tuples.

Attachments (1)

15023.diff (847 bytes) - added by timo 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by timo

comment:1 Changed 6 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 6 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

(In [15149]) Fixed #15023 -- Made US states list a tuple to be a bit more backwards compatible after r15058. Thanks, timo.

comment:3 Changed 5 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top