Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#15023 closed (fixed)

us_states.STATE_CHOICES, USPS_CHOICES should be tuples, not lists

Reported by: Tim Graham Owned by: nobody
Component: contrib.localflavor Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Since r15058 these lists are sorted but that makes them lists instead of tuples. To be backwards compatible and for consistency with the other choices, I think they should be tuples.

Attachments (1)

15023.diff​ (847 bytes ) - added by Tim Graham 13 years ago.

Download all attachments as: .zip

Change History (4)

by Tim Graham, 13 years ago

Attachment: 15023.diff​ added

comment:1 by Russell Keith-Magee, 13 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:2 by Jannis Leidel, 13 years ago

Resolution: → fixed
Status: new → closed

(In [15149]) Fixed #15023 -- Made US states list a tuple to be a bit more backwards compatible after r15058. Thanks, timo.

comment:3 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top