Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#15023 closed (fixed)

us_states.STATE_CHOICES, USPS_CHOICES should be tuples, not lists

Reported by: Tim Graham Owned by: nobody
Component: contrib.localflavor Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Since r15058 these lists are sorted but that makes them lists instead of tuples. To be backwards compatible and for consistency with the other choices, I think they should be tuples.

Attachments (1)

15023.diff (847 bytes) - added by Tim Graham 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Tim Graham

Attachment: 15023.diff added

comment:1 Changed 6 years ago by Russell Keith-Magee

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 6 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

(In [15149]) Fixed #15023 -- Made US states list a tuple to be a bit more backwards compatible after r15058. Thanks, timo.

comment:3 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top