[patch] MySQL AutoField should be int, not mediumint
|Reported by:||ejf-django@…||Owned by:||adrian|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
I believe that the AutoField mapping in core/db/backends/mysql.py DATA_TYPES should be changed from:
'AutoField': 'mediumint(9) unsigned auto_increment'
'AutoField': 'int(10) unsigned auto_increment'
However, currently MySQL ForeignKey references go to 'int(11)', or signed integers. I'm not really clear where in the code that is happening, but ForeignKey references should be changed to unsigned ints.
There are several reasons for this:
- We are arbitrarily limiting the table size, with the only benefit being one byte saved per row (mediumint storage is 3 bytes, int is 4)
- INT is the canonical primary key for MySQL
- PostgreSQL serial defaults to an INT, and is used as such in Django. Therefore MySQL Django created tables are limited compared to the equivalant Django code run against PostgreSQL. We should strive for equivalency.
Change History (5)
comment:1 Changed 9 years ago by ejf-django@…
- Summary changed from MySQL AutoField should be int, not mediumint to [patch] MySQL AutoField should be int, not mediumint