Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#14998 closed (fixed)

'/'.join should use os.path.join

Reported by: CarlFK Owned by: nobody
Component: Contrib apps Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


static_files = [location and '/'.join([location, fn]

Shouldn't that use os.path.join()?

Change History (4)

comment:1 Changed 6 years ago by Russell Keith-Magee

milestone: 1.3
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted


comment:2 Changed 6 years ago by Jannis Leidel

Hm, it's actually not required since the path will be consumed by a storage class ( which calls os.path.normpath, converting all forward slashes to backward slashes. I agree it could be changed to always return platform specific relative paths of course, but I see this more as a cosmetic problem.

comment:3 Changed 6 years ago by Alex Gaynor

Resolution: fixed
Status: newclosed

Fixed in [15128].

comment:4 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top