Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#14982 closed (fixed)

EMPTY_CHANGELIST_VALUE not honored whit a relation field in list_display

Reported by: marcob Owned by: nobody
Component: Uncategorized Version: 1.2
Severity: Keywords: blocker, regression
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This problem was fixed in #11297 but it came back again with 1.2.4.
Simple patch attached.

Attachments (2)

none_value.11297.1.2.4.diff (912 bytes ) - added by marcob 13 years ago.
empty_changelist_value.patch (2.9 KB ) - added by John Anderson 13 years ago.
fixes the issue and has a unit test

Download all attachments as: .zip

Change History (9)

by marcob, 13 years ago

Attachment: none_value.11297.1.2.4.diff added

comment:1 by Russell Keith-Magee, 13 years ago

Has patch: set
Needs tests: set
Patch needs improvement: set
Triage Stage: UnreviewedAccepted

It isn't just 1.2.4 - this existed in 1.2. I'm guessing it's a regression from the introduction of readonly fields.

comment:2 by Ramiro Morales, 13 years ago

Yes, this is because the triager of #11297 closed it without verifying if the issue reported was effectively fixed.

comment:3 by Russell Keith-Magee, 13 years ago

Keywords: blocker regression added

comment:4 by Jannis Leidel, 13 years ago

milestone: 1.3

by John Anderson, 13 years ago

fixes the issue and has a unit test

comment:5 by John Anderson, 13 years ago

Needs tests: unset
Patch needs improvement: unset

Here is a new patch that solves the issue and has unit tests. It doesn't show up in the preview but if you click original format the patch shows up.

comment:6 by Russell Keith-Magee, 13 years ago

Resolution: fixed
Status: newclosed

(In [15286]) Fixed #14982 -- Ensure that EMPTY_CHANGELIST_VALUE is honored for nullable foreign keys. Thanks to marcob for the report and fix, and to sontek for the test case.

comment:7 by Jacob, 12 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top