Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#14973 closed (fixed)

AdminEmailHandler doesn't include report.message

Reported by: jamstooks Owned by: nobody
Component: Core (Other) Version: 1.3-alpha
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Shouldn't the message from the report be included in the email?

# django/utils/log.py line 89
message = "%s\n\n%s" % (stack_trace, request_repr)

I wasn't sure what the intension here was for excluding the message, so I didn't build a patch for that yet, but it could be something as simple as:

message = "%s\n\n%s\n\n%s" % (record.message, stack_trace, request_repr)

Change History (4)

comment:1 Changed 4 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Historically, this hasn't been an issue because there was only one circumstance under which an admin email would be sent -- an internal server error.

With the introduction of logging, there are other circumstances, so yes, it makes sense to include the record.message.

My inclination would be to put record.message in the subject of the message, replacing the current use of record.path. (line 74, where the subject is constructed).

This is finessing a 1.3 feature, so it's 1.3 targeted, but not release blocking.

comment:2 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [15132]) Fixed #14973 -- Tweaked the email log handler so that the log message is actually reported.

comment:3 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

comment:11 Changed 3 years ago by jezdez

In [17512]:

Fixed AdminEmailHandler to format the subject message correctly when arguments are passed.

This bug was hidden before r17480 as it basically didn't take the arguments into account. Refs #14973.

Note: See TracTickets for help on using tickets.
Back to Top