#14973 closed (fixed)
AdminEmailHandler doesn't include report.message
Reported by: | jamstooks | Owned by: | nobody |
---|---|---|---|
Component: | Core (Other) | Version: | 1.3-alpha |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Shouldn't the message from the report be included in the email?
# django/utils/log.py line 89 message = "%s\n\n%s" % (stack_trace, request_repr)
I wasn't sure what the intension here was for excluding the message, so I didn't build a patch for that yet, but it could be something as simple as:
message = "%s\n\n%s\n\n%s" % (record.message, stack_trace, request_repr)
Change History (4)
comment:1 by , 14 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Historically, this hasn't been an issue because there was only one circumstance under which an admin email would be sent -- an internal server error.
With the introduction of logging, there are other circumstances, so yes, it makes sense to include the record.message.
My inclination would be to put record.message in the subject of the message, replacing the current use of record.path. (line 74, where the subject is constructed).
This is finessing a 1.3 feature, so it's 1.3 targeted, but not release blocking.